Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for constant column in STWO backend #2112

Merged
merged 51 commits into from
Dec 11, 2024
Merged

Add support for constant column in STWO backend #2112

merged 51 commits into from
Dec 11, 2024

Conversation

ShuangWu121
Copy link
Collaborator

@ShuangWu121 ShuangWu121 commented Nov 19, 2024 •
edited
Loading

Add Support for Constant Columns in Stwo Backend

Stwo's recent development introduced new APIs to support constant/pre-processed columns. However, the dev branch of Stwo is still using an older nightly toolchain, which is incompatible with Powdr.

Currently, Stwo has two open PRs PR1, PR2 aimed at updating the toolchain to nightly 11-06. Previously, our Stwo backend dependency relied on one of these PRs' branches. However, this branch is no longer updated with the latest commits from their dev branch. These new commits are required to support constant columns.

Temporary Solution

To address this issue temporarily:

  • I moved Stwo's dependency to my fork of Stwo, where the branch is updated with both the latest dev branch commits and the newer toolchain.

Tasks in this PR

  1. Add APIs to support constant columns:
  2. Update test cases:
    • Modify and add test cases to validate constant column support.

@ShuangWu121 ShuangWu121 marked this pull request as ready for review November 25, 2024 12:19
Schaeff
Schaeff reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@Schaeff Schaeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but it seems it can be simplified

backend/Cargo.toml Outdated Show resolved Hide resolved
backend/src/stwo/circuit_builder.rs Show resolved Hide resolved
backend/src/stwo/circuit_builder.rs Outdated Show resolved Hide resolved
backend/src/stwo/circuit_builder.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
Schaeff
Schaeff reviewed Dec 9, 2024
View reviewed changes
backend/src/stwo/proof.rs Outdated Show resolved Hide resolved
backend/src/stwo/circuit_builder.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
backend/src/stwo/prover.rs Outdated Show resolved Hide resolved
@Schaeff Schaeff added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit ad40956 Dec 11, 2024
16 checks passed
@Schaeff Schaeff deleted the stwo-constant-support branch December 11, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schaeff Schaeff Schaeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShuangWu121 @Schaeff